perf(StringRedisTemplate): avoid redundant logger creation in execute(). #3173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Static logger eliminates expensive initialization per invocation. Signed-off-by: huangcanda <[email protected]>
huangcanda
force-pushed
the
fix/string-redis-template-connection-perf
branch
from
dcd43b7 to
41d4bda
Compare
mp911de
added
type: task
|
Thanks for the heads up. There are a couple of other places in the codebase as well that would benefit from this kind of change. Would you like have a look and extend the PR to those, or should we take care of the rest. |
christophstrobl
added
the
status: waiting-for-feedback
|
Sure, I’d be happy to extend the PR. However, since my initial change was based on a specific performance issue I encountered, I haven’t done a full review of the codebase. If you could point me to the places you think would benefit from similar optimizations, I’ll gladly take a look and update the PR accordingly. |
spring-projects-issues
added
status: feedback-provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Each invocation of
StringRedisTemplate.execute()creates a newDefaultStringRedisConnectioninstance, resulting in repeated initialization of non-static logger instances. This causes redundantLogFactorylookups that consume an additional 10–15% CPU overhead.Solution
Modify the
private final Log loggerfield inDefaultStringRedisConnectiontoprivate static final Log logger.Impact
10–15% reduction in CPU overhead for all Redis client command executions.